Feature #1533
open
Separate the window handling from the TBF more clearly
Added by zecke about 8 years ago.
Updated almost 7 years ago.
Description
**The window handling can be more clearly separated from the TBF. This includes clean-ups to the ::assemble_forward_llc. The general multitude of calling dir.dl.window.m_v_b anddir.dl.window.increment_send.
From Jacob:
The situation has much improved with the edge related update of the window handling, but the update functions in the TBF and RLC window class haven't changed really.
The RBB layout is fully abstracted in decoding.cpp now, only a bitvec and the first BSN are passed around.
- Priority changed from Normal to Low
- Status changed from New to Feedback
I'm not quite sure what else can be done in here. The "window.m_v_b" is used in tbf_dl.cpp only and half of the time is in analyse_errors() functions to obtain stats data, increment_send() is used only once. It's also unclear which are the "update functions in the TBF" referred to in comments. I think we should either have much clearer description with actionable steps or close this altogether.
- Assignee changed from msuraev to zecke
- Related to Bug #1759: Wrong calculation of DL window size for DL assignment added
Also available in: Atom
PDF
