Bug #2757
closed
rate_ctr_group_alloc with identical index doesn't return error
Added by laforge over 6 years ago.
Updated about 6 years ago.
Description
As seen by the bug fixed in Change-Id I1b56f8d7b47597ed263e6808074483edca0895de of osmo-bts.git, (https://gerrit.osmocom.org/#/c/5344) the rate_ctr_group_alloc() function appears to accept allocation of the same counter group for identical index, which is of course an error.
Let's make sure we return an error, and also make sure that all known callers actually deal with the error somehow (e.g. if the BTS counters couldn't be allocated, the entire BTS allocation should fail).
- Status changed from New to In Progress
- % Done changed from 0 to 50
Fix for the library is available in gerrit 5418. We should also make sure that all the callers properly check and handle allocation error (which they should because there're other error paths in allocation function as well).
- Status changed from In Progress to Resolved
- % Done changed from 50 to 100
Checked that callers in osmo-msc, osmo-bsc, osmo-bts, osmo-sgsn, osmo-hlr, osmo-ggsn, osmo-pcu handle it properly.
- Status changed from Resolved to In Progress
- % Done changed from 100 to 80
OsmoBSC tests are failing after libosmocore upgrade which seems to be related.
Fix for osmo-bsc available in gerrit 5486. Test failure in osmo-pcu are next.
- % Done changed from 80 to 90
Gerrit 5486 has been merged, fix for osmo-pcu is available in gerrit 5487. The rest doesn't seem to be affected.
- Status changed from In Progress to Resolved
- % Done changed from 90 to 100
- Status changed from Resolved to In Progress
- % Done changed from 100 to 90
OsmoBSC fix got to be backported to OpenBSC.
Fix for OpenBSc is available in gerrit 5491.
- Status changed from In Progress to Stalled
- Status changed from Stalled to Resolved
- % Done changed from 90 to 100
Also available in: Atom
PDF
