Project

General

Profile

Bug #4034

Bad default value for number of endpoints

Added by balister over 1 year ago. Updated 8 months ago.

Status:
Resolved
Priority:
High
Assignee:
Category:
-
Target version:
-
Start date:
05/31/2019
Due date:
% Done:

100%

Spec Reference:

Description

I am setting up a single board cell on a pi3 using the raspbian packages. Well sorting through the config fils trying to setup a working sms and voice config, I ran across a strange issue with the number endpoints setting in osmo-mgw.cfg.

If I comment out:

! number endpoints 31

I see:

number endpoints 4294967295

using the vty interface to show the running config

Setting it in the config file:

number endpoints 31

and restarting, then checking the running config via the vty interface shows the expected value:

number endpoints 31

History

#1 Updated by laforge 8 months ago

  • Assignee set to laforge
  • Priority changed from Normal to High

#2 Updated by laforge 8 months ago

  • Status changed from New to In Progress
  • % Done changed from 0 to 80

I can confirm this bug is still present. It's a bit odd, as we seem to do initialize tcfg->vty_number_endpoints to 33 in mgcp_trunk_alloc() and then subsequently set tcfg->number_endpoints to tcfg->vty_number_endpoints in mgcp_endpoints_allocate()

The problem arises from the fact that the 'default trunk' is statically allocated and has some special treatment - hence it never goes through that path :(

Patch in https://gerrit.osmocom.org/c/osmo-mgw/+/17422

#3 Updated by laforge 8 months ago

For the record, this bug was introduced in change-id I3994af016fb96427263edbba05f560743f85fdd4 in November 2017 while fixing #2632

#4 Updated by laforge 8 months ago

Affected versions 1.3.0-1.7.0

#5 Updated by laforge 8 months ago

  • Status changed from In Progress to Resolved
  • % Done changed from 80 to 100

patch merged.

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 48.8 MB)