Actions
Bug #4381
closedosmo-pcu: decode_gsm_rlcmac_uplink() has all return codes from csnStreamDecoder() disabled
Start date:
01/28/2020
Due date:
% Done:
100%
Spec Reference:
Description
For instance:
case MT_PACKET_CONTROL_ACK:
{
/*ret =*/ csnStreamDecoder(&ar, CSNDESCR(Packet_Control_Acknowledgement_t), vector, readIndex, &data->u.Packet_Control_Acknowledgement);
break;
}
This function AFAIR returns 0 on success and negative on error. We should return an error and fail in decode_gsm_rlcmac_uplink() (which now returns void...). If decode_gsm_rlcmac_uplink() fails, then probably drop the packet instead of assuming the decoded content is correct.
Actions
