Cellular Network Infrastructure » Core Network (CN) » OsmoHNBGW

Wrong commit checked out¶

Neels noted that ttcn3-hnbgw-test had been using the wrong docker-playground.git commit 395cdbb41 instead of current HEAD of master 85f0b31. This happened over several days now.

As I understand, this happened:

• Neels tested with branch neels/hnbgw-pfcp that had 85f0b31 as HEAD
• This commit was merged into master: https://gerrit.osmocom.org/c/docker-playground/+/29339
• jenkin's git cache got confused when building with branch master again and kept checking out the previous commit 395cdbb41

Wiping the workspace didn't fix it. I also ssh'd into the node and verified that it really deletes the entire workspace, it doesn't leave a .git directory behind.
Apparently git repositories get cached on the jenkins master and we could delete it there (https://stackoverflow.com/a/47185763), I didn't try that.

What helped was explicitly building with 85f0b311f983254a74b8d532abc8ac525df1e9df (set it as BRANCH here: https://jenkins.osmocom.org/jenkins/job/ttcn3-hnbgw-test/build). Then it used that commit, and when building again with the default of "*/master", it picks this proper commit now instead of the previous one. (I also looked if "*/master" could match another branch, but we don't have another in there that ends in master.)

osmo-hnbgw doesn't build¶

So now the proper docker-playground.git commit is getting checked out. But osmo-hnbgw doesn't build:

https://jenkins.osmocom.org/jenkins/job/ttcn3-hnbgw-test/229/console

hnbgw.c:255:6: warning: implicit declaration of function 'msgb_sctp_msg_flags'; did you mean 'msgb_sctp_stream'? [-Wimplicit-function-declaration]
  255 |  if (msgb_sctp_msg_flags(msg) & OSMO_STREAM_SCTP_MSG_FLAGS_NOTIFICATION) {
      |      ^~~~~~~~~~~~~~~~~~~
      |      msgb_sctp_stream
hnbgw.c:255:33: error: 'OSMO_STREAM_SCTP_MSG_FLAGS_NOTIFICATION' undeclared (first use in this function)
  255 |  if (msgb_sctp_msg_flags(msg) & OSMO_STREAM_SCTP_MSG_FLAGS_NOTIFICATION) {
      |                                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

neels: you are more familiar with the code, passing to you.