Bug #5747
closedConfiguration created via the vty is broken (% Invalid log level 0 for itap / q931)
0%
Description
'write' in the vty creates a broken config: "% Invalid log level 0 for itap / q931" is inserted in the log section
Used versions:
osmo-isdntap (v0~git20221017 - master from 07.11.2022)
libosmocore (v1.7.0.63 - master from 05.11.2022)
How to reproduce:
start with an empty configuration
echo "" > /etc/osmocom/osmo-isdntap.cfgstart osmo-isdntap
osmo-isdntap -c /etc/osmocom/osmo-isdntap.cfgtelnet 127.0.0.1 4270
osmo-isdntap> en
osmo-isdntap# conf t
osmo-isdntap(config)# isdntap
osmo-isdntap(config-isdntap)# line XXX dahdi TE2/0/1
osmo-isdntap(config-isdntap-line)# local-role network
osmo-isdntap(config-isdntap-line)# exit
osmo-isdntap(config-isdntap)# gsmtap remote-host 192.168.200.2
osmo-isdntap(config-isdntap)# output-path /tmp/
osmo-isdntap(config)# exit
osmo-isdntap# writeresults in a config that erroneously adds
% Invalid log level 0 for itap
% Invalid log level 0 for q931Files
Updated by laforge over 1 year ago
- Assignee set to laforge
this is really strange, I cannot reproduce this. at leats not without adding a DAHDI line (which I don't have on my development laptop right now). But I fail to see how the presence or absence of a DAHDI line would impact log configuration vty output...
Updated by laforge over 1 year ago
the log categories are both defined in src/log.c and we are calling osmo_init_logging2 from main, so I'm really not sure how this should be happening.
Updated by laforge over 1 year ago
- Status changed from New to Feedback
- Assignee changed from laforge to roox
even on divf.retronetworking.org the code (running with about 10 dahdi lines configured for isdntap) generates proper logging config:
log stderr logging filter all 1 logging color 1 logging print category-hex 1 logging print category 0 logging print thread-id 0 logging timestamp 0 logging print file 1 logging level itap info logging level q931 info logging level lglobal notice logging level llapd notice logging level linp notice logging level lmux notice logging level lmi notice logging level lmib notice logging level lsms notice logging level lctrl notice logging level lgtp notice logging level lstats notice logging level lgsup notice logging level loap notice logging level lss7 notice logging level lsccp notice logging level lsua notice logging level lm3ua notice logging level lmgcp notice logging level ljibuf notice logging level lrspro notice logging level lns notice logging level lbssgp notice logging level lnsdata notice logging level lnssignal notice logging level liuup notice logging level lpfcp notice logging level lcsn1 notice
Updated by roox over 1 year ago
laforge wrote in #note-3:
even on divf.retronetworking.org the code (running with about 10 dahdi lines configured for isdntap) generates proper logging config:
[...]
I can't reproduce the error anymore after updating to today's nightly packages (git master, 08.11.2022 22:00) and a reboot of the affected machine.
Updated by laforge over 1 year ago
- Status changed from Feedback to Rejected
ok, then maybe some ABI breakage with libosmocore. we don't guarantee ABI stability for != latest.
