Miscellaneous Projects » Core testing infrastructure

I've had osmo-bsc/tests/ctrl_test_runner.py fail on me (make distclean didn't help either) seemingly inexplicably.

What seems to be happening is the script osmo-python-tests/scripts/osmotestconfig.py tries to copy the config directory to osmo-bsc/writtenconfig, and along the way - if osmo-bsc/tests/ctrl_test_runner.py exited before teardown of the testcase occurred, e.g. due to cancellation - it encounters an error due to trying to copy a socket file (tmp_dummy_sock), resulting in a very unspecific/misleading error (see https://github.com/python/cpython/issues/81881) and exits:

(osmo-python-tests/scripts/osmopythontestconfig.py: 42)

    # If there's a socket error, skip the rest of the tests for this config
    except IOError:
        return 1

I would suggest the following, unless there is a good reason why none of this has been done before (I suppose there isn't...):

• ignore all files tmp_dummy_sock in shutil in osmo-python-tests/scripts/osmotestconfigpython.py
• register a signal handler to clean up such files in osmo-bsc/tests/ctrl_test_runner.py
• fix make clean, make distclean to cleanup such files

Possibly related: OS#5665