Actions
Feature #6319
openprotocol version should have a defined end marker
Start date:
12/25/2023
Due date:
% Done:
0%
Description
in osmo-cc-v0.91.pdf I read:
When a connection is established, both ends send a version string of eight bytes: “OSMOCCv1” first. (no \0 termination, no line feed, case sensitive) The Version number is defined by the eighth byte. In this case the protocol version is ‘1’.
I think it would be better to make this more flexible than a single version char.
I was thinking, what happens when we reach "OSMOCCv10"? It cannot be distinguished from "OSMOCCv1" followed by an unrelated "0".
So I guess it should actually be \0 terminated, or it should be in a TLV, or it should be defined that the version string is sent in a single TCP packet where the entire payload is just the version string? Something that allows extending the string in the future.
What do you think?
Actions