Cellular Network Infrastructure » Radio Access Network » OsmoBSC

There are three types of errors:

• affected:
  • ttcn3-bsc-test-latest
  • ttcn3-bsc-test
• failing tests:
  • TC_ctrl
  • TC_oml_unknown_unit_id

• affected:
  • ttcn3-bsc-test-sccplite
• failing tests:
  • TC_ho_int
  • TC_ho_out_fail_*
  • TC_ho_out_of_this_bsc

• affected:
  • ttcn3-bsc-test-sccplite
  • ttcn3-bsc-test-sccplite-latest
  • ttcn3-bsc-test-latest
  • ttcn3-bsc-test
• failing tests:
  • TC_assignment_csd
  • TC_assignment_ctm
  • all from TC_bssap_rsld_does_not_cause_bssmap_reset to TC_chan_rel_rll_rel_ind
  • ... (many more!)

Regarding c): I've reproduced it locally, and found that reverting commit "RAN_Adapter: invert check for RAN_ops == omit" in osmo-ttcn3-hacks.git fixes it: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15233

Regarding b): I'm assuming that we don't care if handover related tests pass with sccplite, so this can be ignored. It seems that the tests were passing before, although they should not have been passing, and now they are correctly failing.

Regarding a): "5 builds ago" is when new TC_ho_neighbor_config_* tests were introduced, and related osmo-bsc config changes were made (see https://gerrit.osmocom.org/q/topic:ho ). Note that the sccplite related tests are not failing, so this might be a config related issue (the sccplite tests have their own osmo-bsc.cfg, and that one was not modified).

So only a) is remaining, I'm on it :)

• https://gerrit.osmocom.org/c/docker-playground/+/15235
• https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15234

The TC_oml_unknown_unit_id failure is caused by changes in docker-playground.git, it passed locally when I checked out a ~3 weeks old commit ef8b48516e0d5215a92dfe6de32983a450f4ed42.

Fix for TC_oml_unknown_unit_id: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15254

Now that the > 60 failing tests we had yesterday are resolved, it appears that we have one more failing test since yesterday: TC_paging_resp_unsol

This should be the last one, after which everything is back to like it was before this regression wave.

I'm looking into resolving this one too.

• https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15208
• https://gerrit.osmocom.org/c/osmo-bsc/+/15209

Maybe it would have been better to wait with merging the osmo-ttcn3-hacks patch until the osmo-bsc patch was merged?

laforge wrote:

we also need to figure out how related patches ended up untested in the code tree in the first place.

The patch that caused the most fall out is this library change:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15157

It looks good, but since we don't automatically run the TTCN3 tests in gerrit verification, it was not clear that this breaks the BSC testsuite. From reading the commit message, it seems like it was probably manually tested against SGSN tests, and testing manually against all testsuites does not seem feasible.

I understand that it is not feasible right now to run the TTCN3 tests in the gerrit verification job either (due to the long execution times, especially if there is a library change), but hopefully we can get there eventually? I would be happy to work on this if it seems realistic and we can fit it in at some point in the future.

All related patches to fix the regressions are merged, setting this issue to resolved.
https://gerrit.osmocom.org/q/topic:ttcn3-fix-bsc