Project

General

Profile

Actions

Bug #6331

closed

Regression in update_binary_decoded

Added by pdunn 3 months ago. Updated 3 months ago.

Status:
Resolved
Priority:
High
Assignee:
Category:
-
Target version:
-
Start date:
01/18/2024
Due date:
% Done:

100%

Spec Reference:

Description

I have been encountering an issue with update_binary_decoded, not accepting text values as documented. The regression, compared to documented behavior appears to be here: https://gitea.osmocom.org/sim-card/pysim/blame/branch/master/pySim/filesystem.py#L625

example:

pySIM-shell (00:MF/ADF.USIM/EF.IMSI)> update_binary_decoded '{ "imsi": "111111111111111" }'
usage: update_binary_decoded [-h] [--json-path JSON_PATH] data
update_binary_decoded: error: argument data: invalid is_hexstr value: '{ "imsi": "111111111111111" }'

pySIM-shell (00:MF/ADF.USIM/EF.IMSI)> update_binary_decoded --json-path imsi "111111111111111"
usage: update_binary_decoded [-h] [--json-path JSON_PATH] data
update_binary_decoded: error: argument data: invalid is_hexstr value: '111111111111111'
pySIM-shell (00:MF/ADF.USIM/EF.IMSI)>

Actions #1

Updated by fixeria 3 months ago

  • Assignee set to laforge

Most likely a regression of https://gerrit.osmocom.org/c/pysim/+/35551. IMSI is 15-digits, while is_hexstr() expects even number of digits.

Actions #2

Updated by laforge 3 months ago

  • Status changed from New to In Progress
  • Priority changed from Normal to High
Actions #3

Updated by laforge 3 months ago

Should be fixed in https://gerrit.osmocom.org/c/pysim/+/35612 - sorry for that regression.

Actions #4

Updated by laforge 3 months ago

  • Status changed from In Progress to Resolved
  • % Done changed from 0 to 100

patch was merged. If you still experience the problem, please reopen / report back.

Actions

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 48.8 MB)