SIM card related Projects » osmo-remsim

the question is first to understand why it fails. To my knowledge, it has not been failing
at the time the last release was made. Let's not take hectic steps that may simply cover up
what may be an underlying backwards incompatibility we may have introduced in a library package.

Right. Latest is failing with:

[  504s] dh_missing: usr/lib/x86_64-linux-gnu/libosmo-rspro.so.1.0.0 exists in debian/tmp but is not installed to anywhere
[  504s] dh_missing: usr/lib/x86_64-linux-gnu/libosmo-rspro.so.1 exists in debian/tmp but is not installed to anywhere
[  504s] dh_missing: missing files, aborting

This was fixed after the release in this patch:
https://gerrit.osmocom.org/c/osmo-remsim/+/16498

add missing debian/libosmo-rspro1.install

In Change-Id I77c86455f9c36c16271bc8e7f8f3f72d682d23fd for some
reason libosmo-rspro0.install was not renamed/moved but deleted,
causing failures to build debian packages

Change-Id I77c86455f9c36c16271bc8e7f8f3f72d682d23fd is the "Bump version: 0.2.1.10-35d9-dirty → 0.2.2" commit, in which the libosmo-rspro1.install file really was deleted. So the issue started appearing when the last release was cut and can be fixed with either a new release, or by creating a new release with just that one fixup patch.

There have been a lot of additional commits since the last release, so what's the better approach?

So last tag is 0.2.2, but it's out of "master" direct ancestor tree. Last tagged direct ancestor is 0.2.1.

In 0.2.1 we have :RSPRO_LIBVERSION=0:0:0, and in 0.2.2 we already have RSPRO_LIBVERSION=1:0:0

In OBS log we see:

[  164s]    dh_install -O--fail-missing
[  164s] dh_install: usr/lib/x86_64-linux-gnu/libosmo-rspro.so.1 exists in debian/tmp but is not installed to anywhere
[  164s] dh_install: usr/lib/x86_64-linux-gnu/libosmo-rspro.so.1.0.0 exists in debian/tmp but is not installed to anywhere

Diff of debian/ 0.2.2..master:

diff --git a/debian/control b/debian/control
index 7638015..e7f52f3 100644
--- a/debian/control
+++ b/debian/control
@@ -12,6 +12,7 @@ Build-Depends: debhelper (>= 9),
                libcsv-dev,
                libosmocore-dev,
                libosmo-abis-dev,
+               libosmo-simtrace2-dev,
                libpcsclite-dev,
                libusb-1.0-0-dev,
                libulfius-dev,

So everything else is the same and hence should show no issues (I checked LIBVERSION is kept as RSPRO_LIBVERSION=1:0:0).

Opening osmo-remsim_0.2.2.tar.gz available in OBS (the one used to build in latest). I see that debian/ is missing the libosmo-rspro1.install file (also no libosmo-rspro0.install)

Even version 0.2.1 or 0.2.0 contain at least libosmo-rspro0.install, so I'm not sure what happened when that tar.gz was created... It seems to be the only install file missing.

osmith wrote:

the question is first to understand why it fails. To my knowledge, it has not been failing
at the time the last release was made. Let's not take hectic steps that may simply cover up
what may be an underlying backwards incompatibility we may have introduced in a library package.

Right. Latest is failing with:

[...]

This was fixed after the release in this patch:
https://gerrit.osmocom.org/c/osmo-remsim/+/16498

add missing debian/libosmo-rspro1.install

In Change-Id I77c86455f9c36c16271bc8e7f8f3f72d682d23fd for some
reason libosmo-rspro0.install was not renamed/moved but deleted,
causing failures to build debian packages

Change-Id I77c86455f9c36c16271bc8e7f8f3f72d682d23fd is the "Bump version: 0.2.1.10-35d9-dirty → 0.2.2" commit, in which the libosmo-rspro1.install file really was deleted. So the issue started appearing when the last release was cut and can be fixed with either a new release, or by creating a new release with just that one fixup patch.

There have been a lot of additional commits since the last release, so what's the better approach?

Ah good catch. However, see in the git tree that the release tag is not on that specific commit, but on one done by me which is not a direct ancestor of master. And in my commit that bug is not there, the file was renamed instead :) So if it took my tagged commit, the issue shouldn't happen.... so it seems our OBS trigger script from osmo-ci is not fetching the correct commit? That's weird.

To easily understand what I mean:

$ git diff b2f783b11b27a93ebce790edb4870413d47a3566..b2a00776a04cd826a1c39bfb8e9cc5879e25f761
diff --git a/debian/changelog b/debian/changelog
index 48af70b..0ff1dea 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -16,7 +16,7 @@ osmo-remsim (0.2.2) unstable; urgency=medium
   * remsim-apitool.py: pass IDs as integer
   * client: fix help strings

- -- Pau Espin Pedrol <pespin@sysmocom.de>  Tue, 03 Dec 2019 20:27:56 +0100
+ -- Harald Welte <laforge@osmocom.org>  Tue, 03 Dec 2019 20:38:18 +0100

 osmo-remsim (0.2.1) unstable; urgency=medium

diff --git a/debian/libosmo-rspro1.install b/debian/libosmo-rspro1.install
deleted file mode 100644
index 2b3a85d..0000000
--- a/debian/libosmo-rspro1.install
+++ /dev/null
@@ -1 +0,0 @@
-usr/lib/*/libosmo-rspro*.so.*

debian/changelog from the tar.gz available in OBS shows:

osmo-remsim (0.2.2) unstable; urgency=medium
...
 -- Harald Welte <laforge@osmocom.org>  Tue, 03 Dec 2019 20:38:18 +0100

So for some reason it's taking the commit from master ancestor instead of the tagged release...

OH! interesting:

$ git fetch --tags
From ssh://gerrit.osmocom.org:29418/osmo-remsim
 ! [rejected]        0.2.2      -> 0.2.2  (would clobber existing tag)

So it seems we have a git tag collision there.... I probably tried to push mine some time ago without git fetching before and I didn't notice the error, so probably my 0.2.2 tag is different than everyone else...

I ended up creating a new patch release 0.2.3 in a release branch out of 0.2.2:

remote: https://gerrit.osmocom.org/c/osmo-remsim/+/16776 add missing debian/libosmo-rspro1.install
remote: https://gerrit.osmocom.org/c/osmo-remsim/+/16777 Bump version: 0.2.2.1-660b → 0.2.3

Once merged I need to push the 0.2.3 tag.

Thanks for resolving this! Patches were merged and tag was created The latest packages for osmo-remsim are building successfully on OBS :)