Actions
Bug #4375
closedRLCMACTest.cpp fails when changing logging levels
Start date:
01/23/2020
Due date:
% Done:
100%
Spec Reference:
Description
I was debugging other issues in a new test I'm adding, and I dropped the empty .err file and increased debug level of DCSN1 to debug the issue, but then existing tests fail:
Changes to reproduce the issue:
diff --git a/tests/rlcmac/RLCMACTest.cpp b/tests/rlcmac/RLCMACTest.cpp
index 61026ed..673bbed 100644
--- a/tests/rlcmac/RLCMACTest.cpp
+++ b/tests/rlcmac/RLCMACTest.cpp
@@ -238,7 +238,7 @@ int main(int argc, char *argv[])
{
void *ctx = talloc_named_const(NULL, 1, "RLCMACTest");
osmo_init_logging2(ctx, &gprs_log_info);
- log_parse_category_mask(osmo_stderr_target, "DPCU,3:DLGLOBAL,1:");
+ log_parse_category_mask(osmo_stderr_target, "DPCU,3:DLGLOBAL,1:DCSN1,2:");
//printSizeofRLCMAC();
testRlcMacDownlink(ctx);
diff --git a/tests/testsuite.at b/tests/testsuite.at
index 8a319bd..fe87ff9 100644
--- a/tests/testsuite.at
+++ b/tests/testsuite.at
@@ -5,8 +5,7 @@ AT_BANNER([Regression tests])
AT_SETUP([rlcmac])
AT_KEYWORDS([rlcmac])
cat $abs_srcdir/rlcmac/RLCMACTest.ok > expout
-cat $abs_srcdir/rlcmac/RLCMACTest.err > experr
-AT_CHECK([$OSMO_QEMU $abs_top_builddir/tests/rlcmac/RLCMACTest], [0], [expout], [experr])
+AT_CHECK([$OSMO_QEMU $abs_top_builddir/tests/rlcmac/RLCMACTest], [0], [expout], [ignore])
AT_CLEANUP
AT_SETUP([multi_slot])
Test output failing:
=========Start ENCODE============= +++++++++Finish ENCODE+++++++++++ vector1 = 40284f00010981c826f446809dcecb2b2b2b2b2b -vector2 = 40284f00010981c826f446809dcecb2b2b2b2b2b -vector1 == vector2 : TRUE +vector2 = 40284f00010982194de88d13b9dab2b2b2b2b2b +vector1 == vector2 : FALSE vector1 = 40243f2f000087b042b2b2b2b2b2b2b2b2b2b2b =========Start DECODE=========== +++++++++Finish DECODE++++++++++
So it can be seen there's a missing 2b (or/and len is 1 byte less). Which means the change in logging makes the program behave differently, which shouldn't happen.
Actions
