Project

General

Profile

Bug #2844

Osmocom-Sanitizer builds broken due to missing sysmocom/superfemto/superfemto.h

Added by laforge 10 months ago. Updated about 2 months ago.

Status:
Resolved
Priority:
Normal
Assignee:
Target version:
-
Start date:
01/20/2018
Due date:
% Done:

100%

Spec Reference:

Description

See https://jenkins.osmocom.org/jenkins/job/Osmocom_Sanitizer/798/console
it seems that one of the recent changes to the configures cript has broken the Osmocom-Sanitizer builds. Please fixup ASAP.


Related issues

Related to Cellular Network Infrastructure - Bug #2845: Coverity-Upload broken due to alleged missing sysmocom/femtobts/superfemto.hResolved2018-01-20

History

#1 Updated by laforge 10 months ago

  • Related to Bug #2845: Coverity-Upload broken due to alleged missing sysmocom/femtobts/superfemto.h added

#2 Updated by msuraev 10 months ago

  • Status changed from New to In Progress
Shouldn't we just remove this job altogether?
  • it tests old openbsc and openggsn
  • it's configured manually instead of job builder's .yml
  • all the projects checked by it has sanitizer enabled in regular gerrit tests

Initially it was just a quick way to check how far we're on the way to make all our projects build cleanly with ASAN. Nowadays we have it integrated in regular CI process. Does it still make sense to have a dedicated manual job for the same task?

#3 Updated by msuraev 10 months ago

  • Status changed from In Progress to Feedback
  • % Done changed from 0 to 90

The build is working again now, but the question whether we need it at all remains open.

#4 Updated by msuraev 10 months ago

  • Assignee changed from msuraev to laforge

#5 Updated by laforge 10 months ago

  • Status changed from Feedback to In Progress
  • Assignee changed from laforge to msuraev
  • Priority changed from Urgent to Low

I'm not sure, as I've never been involved in any of the asan related configuration. If you have confirmed that all regular build jobs now do asan, and there is nothing in the Osmocom-Sanitizer job that we don't already do in those regular build jobs: Remove it.

#6 Updated by msuraev 10 months ago

From the projects checked by this job only OsmoBTS don't have sanitizer enabled yet in CI. This is fixed in gerrit 6014. Once it's merged, it's safe to remove sanitizer job.

#7 Updated by msuraev 10 months ago

Gerrit 6014 is merged. I've not removed the job yet because it still have small difference to per-project setup: the projects build their dependencies without sanitizer. In theory this probably could enable sanitizer to catch additional errors. This should be clarified. Maybe we should just enable sanitizer for all the dependencies via osmo-ci scripts handling them.

#8 Updated by msuraev 10 months ago

  • Status changed from In Progress to Stalled

#9 Updated by laforge 9 months ago

  • Assignee deleted (msuraev)

#10 Updated by laforge about 2 months ago

  • Assignee set to laforge
  • Priority changed from Low to Normal

#11 Updated by laforge about 2 months ago

  • Status changed from Stalled to Resolved
  • % Done changed from 90 to 100

it's failing for completely other reasons at this point (one of which I just fixed), but that's off-topic here.

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 48.8 MB)