Bug #2844
closed
- Related to Bug #2845: Coverity-Upload broken due to alleged missing sysmocom/femtobts/superfemto.h added
- Status changed from New to In Progress
Shouldn't we just remove this job altogether?
- it tests old openbsc and openggsn
- it's configured manually instead of job builder's .yml
- all the projects checked by it has sanitizer enabled in regular gerrit tests
Initially it was just a quick way to check how far we're on the way to make all our projects build cleanly with ASAN. Nowadays we have it integrated in regular CI process. Does it still make sense to have a dedicated manual job for the same task?
- Status changed from In Progress to Feedback
- % Done changed from 0 to 90
The build is working again now, but the question whether we need it at all remains open.
- Assignee changed from msuraev to laforge
- Status changed from Feedback to In Progress
- Assignee changed from laforge to msuraev
- Priority changed from Urgent to Low
I'm not sure, as I've never been involved in any of the asan related configuration. If you have confirmed that all regular build jobs now do asan, and there is nothing in the Osmocom-Sanitizer job that we don't already do in those regular build jobs: Remove it.
From the projects checked by this job only OsmoBTS don't have sanitizer enabled yet in CI. This is fixed in gerrit 6014. Once it's merged, it's safe to remove sanitizer job.
Gerrit 6014 is merged. I've not removed the job yet because it still have small difference to per-project setup: the projects build their dependencies without sanitizer. In theory this probably could enable sanitizer to catch additional errors. This should be clarified. Maybe we should just enable sanitizer for all the dependencies via osmo-ci scripts handling them.
- Status changed from In Progress to Stalled
- Assignee deleted (
msuraev)
- Assignee set to laforge
- Priority changed from Low to Normal
- Status changed from Stalled to Resolved
- % Done changed from 90 to 100
it's failing for completely other reasons at this point (one of which I just fixed), but that's off-topic here.
Also available in: Atom
PDF