Project

General

Profile

Actions

Bug #5659

closed

ttcn3-msc-test regressions since build 1732, 17 days ago

Added by laforge over 1 year ago. Updated 11 months ago.

Status:
Resolved
Priority:
High
Assignee:
Category:
-
Target version:
-
Start date:
08/23/2022
Due date:
% Done:

0%

Resolution:
Spec Reference:

Description

This may have come up before, and IIRC there was some discussion that it's something you're working on, neels ? If my memory is wrong, please re-assing.

It is worrying that for 17 days we see regressions in ttcn3-msc-tests
https://jenkins.osmocom.org/jenkins/view/All%20no%20Gerrit/job/ttcn3-msc-test/ as well as the same regressions in msc-test-latest: https://jenkins.osmocom.org/jenkins/view/All%20no%20Gerrit/job/ttcn3-msc-test-latest/

Any regression is normally discussed in the weekly review and then resolved quickly. It is not our normal workflow to introduce changes into either the IUT (msc) or the test suite that knowingly cause regressions for more than a few days.


Related issues

Related to OsmoMSC - Bug #5529: Inter BSC HO fails due to lack of MSC Preferred Codecs IEResolvedneels04/14/2022

Actions
Actions #1

Updated by fixeria over 1 year ago

If fixing the missing IE is a lot of work, we can temporarily revert this patch:

https://cgit.osmocom.org/osmo-ttcn3-hacks/commit/?id=c5fcb89b8d19a1b66e41c80c07eaa2f67e8a62dc

Actions #2

Updated by fixeria over 1 year ago

  • Related to Bug #5529: Inter BSC HO fails due to lack of MSC Preferred Codecs IE added
Actions #3

Updated by neels over 1 year ago

It is valid to have unit tests that are expected to fail.
At least it is common practice: there is an indicator that some probem is known, and not yet fixed.
Hence I am fine with the tests failing, no matter how long it takes to fix them.

Fixing the issue itself has already happened on the osmo-msc neels/codecs branch,
but before i can submit it for review, i want to do physical testing -- our only way to ensure a proper voice stream.
I hope to be able to start physical testing next week.

It would also be possible to spend additional effort to also fix the missing IE on current master, without waiting for the branch. Currently not deemed necessary, see #5529

Actions #4

Updated by neels 11 months ago

The failing HO tests have been fixed in master by

commit b091d2138dad33a580f7bcce93f482adef366e21
HO Req: include IE Codec List (MSC Preferred)
Change-Id: Ifcf719c5fc9e11749aafbd97bafda7f6f50973ea
Actions #5

Updated by neels 11 months ago

  • Status changed from New to Resolved
Actions

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 48.8 MB)