Bug #6098
closedmaster-dahdi-linux fails for torvalds-master and stable-linux-6.1.y
100%
Description
Since July 14, the master-dahdi-linux jenkins jobs are failing for torvalds-master and stable-linux-6.1.y but continue to pass for stable-linux-5.10.y and stable-linux-4.19.y
The error in question is triggered by the use of -Werror=address
build/drivers/dahdi/xpp/xbus-core.c: In function 'xbus_check_unique': /build/drivers/dahdi/xpp/xbus-core.c:116:13: error: the comparison will always evaluate as 'true' for the address of 'label' will never be NULL [-Werror=address] 116 | if (xbus->label && *(xbus->label)) { | ^~~~ In file included from /build/drivers/dahdi/xpp/xbus-core.c:39: /build/drivers/dahdi/xpp/xbus-core.h:187:14: note: 'label' declared here 187 | char label[LABEL_SIZE]; | ^~~~~ CC [M] /build/drivers/dahdi/voicebus/GpakCust.o CC [M] /build/drivers/dahdi/voicebus/GpakApi.o cc1: all warnings being treated as errors make[3]: *** [scripts/Makefile.build:252: /build/drivers/dahdi/xpp/xbus-core.o] Error 1 make[2]: *** [scripts/Makefile.build:494: /build/drivers/dahdi/xpp] Error 2 make[2]: *** Waiting for unfinished jobs....
I don't understand how this might have changed overnight. I can continue to build it locally on my debian unstable with gcc-12.3.0, even against the debian 6.1.27-1 kernel.
The big qustion is probably where does that -Werror=address
suddenly come from?
We know that DAHDI is full of things that have triggered compiler warnings for years, but we don't want to diverge even more from master than needed, particularly for hardware that we don't have to test any code changes on.
Related issues
Updated by laforge about 1 year ago
in the "worst case" we might simply disable the XPP drivers, if the problems only occur there.
Updated by osmith about 1 year ago
It's caused by the debian 12 migration (#6057), looking into it.
Updated by osmith about 1 year ago
- Related to Feature #6057: Debian 12 support added
Updated by osmith about 1 year ago
- Status changed from Feedback to In Progress
- % Done changed from 0 to 90
but continue to pass for stable-linux-5.10.y and stable-linux-4.19.y
This is because Werror was made default in 5.15.
in the "worst case" we might simply disable the XPP drivers, if the problems only occur there.
It is not only there.
This patch fixes it by setting -Wno-error=address: https://gerrit.osmocom.org/c/dahdi-linux/+/33767
Updated by osmith 12 months ago
- Status changed from In Progress to Resolved
- % Done changed from 90 to 100
Applied in changeset e1-t1-adapter:dahdi-linux|a210405427440651e2f3f611af070d9214a9eb46.