Project

General

Profile

Gerrit » History » Version 33

neels, 07/12/2016 12:56 PM

1 1 zecke
h1. Contributing using Gerrit
2 1 zecke
3 11 laforge
{{>toc}}
4 11 laforge
5 10 laforge
At [[OpenBSC:OsmoDevCon2016]] we discussed problems with our past contribution / patch submission process using mails on the mailing list as well as patchwork.  The result is that we want to give Gerrit a try for some time and see if it helps us to have a better process
6 1 zecke
7 10 laforge
Gerrit is a review tool that integrates nicely with git and ssh. You can find general information about Gerrit at https://www.gerritcodereview.com/
8 1 zecke
9 10 laforge
The advantages of Gerrit are:
10 10 laforge
* patch submission status is automatically tracked, also with several revisions for a patch set.
11 10 laforge
* patches are build-tested (and possibly even further tested) by jenkins before they are applied
12 10 laforge
* developers + maintainers can formally vote on a patch (developer: -1/0/+1, maintainer: -2/0/+2)
13 10 laforge
* once a patch has +2 score, it can be (automatically) merged into master
14 10 laforge
* patch sumissions not via git send-email but direcly from git
15 10 laforge
16 10 laforge
h2. Osmocom Subprojects using Gerrit
17 10 laforge
18 1 zecke
The following projects use Gerrit to contribute changes:
19 1 zecke
20 1 zecke
* libosmocore.git
21 1 zecke
* libosmo-abis.git
22 1 zecke
* libosmo-netif.git
23 1 zecke
* libosmo-sccp.git
24 1 zecke
* libsmpp34.git
25 1 zecke
* openbsc.git
26 1 zecke
* osmo-bts.git
27 1 zecke
* osmo-iuh.git
28 1 zecke
* osmo-pcu.git
29 5 zecke
* cellmgr-ng.git
30 1 zecke
* osmo-sip-connector.git
31 30 neels
32 1 zecke
h2. Configuring Gerrit/Account
33 1 zecke
34 10 laforge
You will need to sign-up at https://gerrit.osmocom.org/login/. If you have an Osmocom Redmine account you can use https://osmocom.org/openid as OpenID provider. If you have no Osmocom redmine account, you can simply create one online at the "Register" link in the upper right corner.
35 10 laforge
36 10 laforge
Even without an existing or new redmine account, you should also be able to use any other OpenID provider to authenticate against gerrit (untested).
37 10 laforge
38 10 laforge
After the initial sign-up you will need to:
39 1 zecke
40 1 zecke
* Pick a username (can not be changed)
41 1 zecke
* Add your public ssh key(s)
42 1 zecke
* Add email addresses you intend to use as author/comitter
43 30 neels
44 30 neels
If you would like to push private branches to the Gerrit repository, you also need to be added to the "known users" group.
45 30 neels
Please send a short requesting email to openbsc@lists.osmocom.org.
46 1 zecke
47 1 zecke
h2. Setting up Gerrit for commits and pushing
48 1 zecke
49 33 neels
*Note:* it is easiest to work with gerrit when gerrit is the only remote in your git clone.
50 33 neels
When you clone from git.osmocom.org and add the gerrit remote, git will have two remotes,
51 33 neels
so when you checkout a new branch you have to supply the remote explicitly (cumbersome).
52 33 neels
53 33 neels
h3. Simplest: new clone
54 33 neels
55 33 neels
Create a new clone from gerrit:
56 33 neels
<pre>
57 33 neels
git clone ssh://$USERNAME@gerrit.osmocom.org:29418/$PROJECT.git
58 33 neels
scp -P 29418 $USERNAME@gerrit.osmocom.org:hooks/commit-msg $PROJECT/.git/hooks/
59 33 neels
</pre>
60 33 neels
61 33 neels
h3. SSH config
62 33 neels
63 33 neels
In '~/.ssh/config', add these lines:
64 33 neels
<pre>
65 33 neels
Host foo
66 33 neels
Hostname gerrit.osmocom.org
67 33 neels
Port 29418
68 33 neels
User $USERNAME
69 33 neels
</pre>
70 33 neels
(replace 'foo' with your favorite shortcut name,
71 33 neels
replace '$USERNAME' with your user name as used on the gerrit website)
72 33 neels
73 33 neels
Then you can shorten above commands to
74 33 neels
<pre>
75 33 neels
git clone ssh://foo/$PROJECT.git
76 33 neels
scp go:hooks/commit-msg $PROJECT/.git/hooks/
77 33 neels
</pre>
78 33 neels
79 33 neels
80 33 neels
h3. Add gerrit to an existing clone
81 33 neels
82 7 neels
* Add the remote to be able to fetch and push to gerrit
83 7 neels
* Fetch the commit hook that adds Change-Id to each commit to uniquely identify a commit
84 7 neels
85 7 neels
<pre>
86 7 neels
USERNAME=gerrit_user_name
87 7 neels
PROJECT=$(basename $PWD)
88 7 neels
git remote add gerrit ssh://$USERNAME@gerrit.osmocom.org:29418/$PROJECT.git
89 7 neels
scp -P 29418 $USERNAME@gerrit.osmocom.org:hooks/commit-msg .git/hooks/
90 7 neels
</pre>
91 7 neels
92 7 neels
* In case your local username matches the gerrit username, the setup shortens to
93 7 neels
94 7 neels
<pre>
95 7 neels
PROJECT=$(basename $PWD)
96 7 neels
git remote add gerrit ssh://gerrit.osmocom.org:29418/$PROJECT.git
97 7 neels
scp -P 29418 gerrit.osmocom.org:hooks/commit-msg .git/hooks/
98 7 neels
</pre>
99 1 zecke
100 33 neels
h2. Push for review
101 7 neels
102 31 neels
<pre>
103 1 zecke
git push gerrit HEAD:refs/for/master
104 1 zecke
</pre>
105 1 zecke
106 33 neels
h2. Push a "private" user branch
107 33 neels
108 33 neels
*Note* that you must be a member of the "known users" group, see above.
109 33 neels
110 33 neels
If gerrit is your only remote, and if your local branch name is of the
111 33 neels
form 'yourname/topic', you can just
112 1 zecke
<pre>
113 33 neels
git push
114 1 zecke
</pre>
115 33 neels
(and git will tell you what to do)
116 1 zecke
117 33 neels
If you have other remotes as well, do
118 1 zecke
<pre>
119 33 neels
git push gerrit
120 31 neels
</pre>
121 7 neels
122 33 neels
To push with a "nonstandard" local branch name, do
123 33 neels
<pre>
124 33 neels
git push gerrit HEAD:refs/heads/$USERNAME/topic
125 33 neels
</pre>
126 33 neels
127 33 neels
h2. List changesets in gerrit
128 7 neels
<pre>
129 7 neels
git ls-remote gerrit changes/*
130 2 zecke
</pre>
131 12 msuraev
132 17 neels
h1. Tips and Tricks
133 1 zecke
134 17 neels
h2. Throw-away branch
135 17 neels
136 17 neels
If you need to adjust and re-submit patches, it may be handy to create a throw-away branch ("R D" in magit-gerrit in emacs for example),
137 17 neels
make your changes/amendments and than send patch(es) back to gerrit while removing temporary branch automatically with "git review -f".
138 13 neels
139 25 neels
h2. Re-submit a Branch with Amended Commits
140 13 neels
141 1 zecke
On a feature branch, one typically has numerous commits that depend on their preceding commits.
142 29 neels
Often, some of the branch commits need to be amended for fixes. But, Gerrit will refuse your branch
143 29 neels
re-submission if the first branch commit is unchanged.
144 1 zecke
145 16 neels
To re-submit a branch, make sure to cosmetically tweak the branch's first commit log message
146 22 neels
before each re-submission (keep the Change-Id, really make just a cosmetic change).
147 13 neels
148 16 neels
<pre>
149 16 neels
git rebase -i master
150 16 neels
# replace the first line's 'pick' with 'r' (or 'reword'), exit editor
151 16 neels
# git presents you with commit log message, make any tiny modification.
152 1 zecke
</pre>
153 1 zecke
154 29 neels
The cause: Gerrit refuses to accept a commit with a Change-Id that it already knows and
155 29 neels
where the commit hash is identical.
156 1 zecke
157 29 neels
If you just cosmetically tweak the first commit's log message, the commit hash
158 29 neels
is changed. Since the following commits contain their predecessor's commit hash, now
159 29 neels
all of the branch's commit hashes are modified, and gerrit happily accepts them as a 
160 29 neels
new patch set. It will still pick up the Change-Ids (which you shouldn't edit) and 
161 29 neels
notice if commits have remained identical (keeping the votes). But with the minor
162 29 neels
commit log tweak, it will no longer thwart your re-submission with an error message.
163 29 neels
164 29 neels
Note: you could modify all the Change-Ids, but now your branch submission would
165 29 neels
open entirely new review entries and you would have to abandon your previous submission.
166 29 neels
Comments on the first submission are lost and you cannot diff between patch sets.
167 29 neels
168 29 neels
169 26 neels
h2. Re-submit Previously Abandoned Changes
170 16 neels
171 16 neels
You have to edit the Change-Ids, on a branch that would be every single commit log message.
172 16 neels
173 13 neels
<pre>
174 1 zecke
cd openbsc
175 1 zecke
git co my-branch
176 1 zecke
git rebase -i master
177 1 zecke
# replace all 'pick' with 'r' (or 'reword'), exit your editor
178 13 neels
# git presents each commit log message for editing
179 13 neels
</pre>
180 13 neels
181 27 neels
h2. Submit a "private" branch for master
182 21 neels
183 21 neels
If you've pushed a branch to refs/heads/* somewhere, gerrit will already know the Change-Ids on it.
184 24 neels
Make sure the option [[Gerrit#Private-Branches-Create-a-new-change-for-every-commit|Create a new change for every commit not in the target branch]] is _TRUE_ for your project,
185 21 neels
or gerrit will refuse to accept your submission.
186 21 neels
187 16 neels
h1. Reasons for Particular Configuration
188 13 neels
189 16 neels
h2. Rebase if necessary
190 16 neels
191 16 neels
There are different merge strategies that Gerrit performs to accept patches.
192 13 neels
Each project can be configured to a specific merge strategy, but unfortunately you can't
193 13 neels
decide on a strategy per patch submission.
194 13 neels
195 13 neels
It seems that the "Merge if Necessary" strategy is best supported, but it creates non-linear
196 13 neels
history with numerous merge commits that are usually not at all necessary.
197 13 neels
198 13 neels
Instead, the "Cherry Pick" strategy puts each patch onto current master's HEAD to create
199 13 neels
linear history. However, this will cause merge failures as soon as one patch depends on
200 13 neels
another submitted patch, as typical for a feature branch submission.
201 13 neels
202 1 zecke
So we prefer the "Rebase if Necessary" strategy, which always tries to apply your patches to
203 13 neels
the current master HEAD, in sequence with the previous patches on the same branch.
204 13 neels
However, some problems still remain, including some bugs in "Rebase if Necessary".
205 1 zecke
206 13 neels
There's a problem with "Rebase if Necessary": If your branch sits at master's HEAD, Gerrit
207 13 neels
refuses to accept the submission, because it thinks that no new changes are submitted.
208 13 neels
This is a bug in Gerrit, which holger has fixed manually in our Gerrit installation:
209 1 zecke
210 1 zecke
https://bugs.chromium.org/p/gerrit/issues/detail?id=4158
211 1 zecke
212 1 zecke
213 16 neels
h2. Private Branches: Create a new change for every commit...
214 1 zecke
215 13 neels
Say you have an extensive feature in development, and you want to keep it on the
216 13 neels
upstream git repository to a) keep it safe and b) collaborate with other devs on it.
217 16 neels
So, of course, you have regularly pushed to refs/heads/yoyodyne/feature.
218 13 neels
219 13 neels
Since you have the gerrit commit hook installed, your feature branch already has
220 13 neels
Change-Id tags in all commit log messages.
221 13 neels
222 13 neels
Now your feature is complete and you would like to submit it to master.
223 13 neels
Alas, Gerrit refuses to accept your patch submission for master, because it
224 13 neels
knows the Change-Ids are also on a different branch.
225 13 neels
226 16 neels
Gerrit by default enforces that a Change-Id must be unique across all branches,
227 16 neels
so that each submission for review is separate for each branch. Instead, we
228 16 neels
want to handle Change-Ids per-branch, so that you can have the same change
229 16 neels
submitted to different branches, as separate patch submissions, without having
230 16 neels
to cosmetically adjust the Change-Id.
231 13 neels
232 16 neels
Solution: set the option 
233 16 neels
_Create a new change for every commit not in the target branch_ to _TRUE_
234 13 neels
235 20 neels
h2. Allow content merges
236 14 neels
237 14 neels
By default, gerrit compares patches only by the files' paths. If two paths are the same,
238 14 neels
it immediately shows them as conflicts (path conflicts).
239 14 neels
240 14 neels
In software development, a conflict usually means an actual content conflict, so if the
241 14 neels
edits are in two entirely separate places in the file, we don't consider this a conflict.
242 14 neels
243 23 neels
By setting _Allow content merges_ to _TRUE_ in the git project config, we tell Gerrit to
244 14 neels
perform text merges of the submitted patches and only complain about actual content
245 14 neels
conflicts, in the usual software engineering sense.
246 32 neels
247 32 neels
h1. Admin
248 32 neels
249 32 neels
h2. Adding users to groups
250 32 neels
251 32 neels
Normally, the gerrit UI auto-completes a user name in the edit field. It has happened
252 32 neels
though that an existing user is not auto-completed, as if it didn't exist. In that case,
253 32 neels
find out the user ID (seven digit number like 1000123) and just enter that.
254 32 neels
255 32 neels
The user ID can be found on the user's "Settings" page, or in the database (s.b.).
256 32 neels
257 32 neels
h2. Querying the database directly
258 32 neels
259 32 neels
If your user has permission to access the database, you can place SQL queries using the
260 32 neels
'gerrit gsql' commands over ssh:
261 32 neels
262 32 neels
<pre>
263 32 neels
ssh -p 29418 $USERNAME@gerrit.osmocom.org 'gerrit gsql --format PRETTY -c "show tables"'
264 32 neels
ssh -p 29418 $USERNAME@gerrit.osmocom.org 'gerrit gsql --format PRETTY -c "select full_name,account_id from accounts"'
265 32 neels
</pre>
266 32 neels
267 32 neels
This seems to be the MySQL dialect.
Add picture from clipboard (Maximum size: 48.8 MB)