Gerrit » History » Version 44
neels, 07/12/2016 01:17 PM
1 | 1 | zecke | h1. Contributing using Gerrit |
---|---|---|---|
2 | |||
3 | 11 | laforge | {{>toc}} |
4 | |||
5 | 10 | laforge | At [[OpenBSC:OsmoDevCon2016]] we discussed problems with our past contribution / patch submission process using mails on the mailing list as well as patchwork. The result is that we want to give Gerrit a try for some time and see if it helps us to have a better process |
6 | 1 | zecke | |
7 | 10 | laforge | Gerrit is a review tool that integrates nicely with git and ssh. You can find general information about Gerrit at https://www.gerritcodereview.com/ |
8 | 1 | zecke | |
9 | 10 | laforge | The advantages of Gerrit are: |
10 | * patch submission status is automatically tracked, also with several revisions for a patch set. |
||
11 | * patches are build-tested (and possibly even further tested) by jenkins before they are applied |
||
12 | * developers + maintainers can formally vote on a patch (developer: -1/0/+1, maintainer: -2/0/+2) |
||
13 | * once a patch has +2 score, it can be (automatically) merged into master |
||
14 | * patch sumissions not via git send-email but direcly from git |
||
15 | |||
16 | h2. Osmocom Subprojects using Gerrit |
||
17 | |||
18 | 1 | zecke | The following projects use Gerrit to contribute changes: |
19 | |||
20 | * libosmocore.git |
||
21 | * libosmo-abis.git |
||
22 | * libosmo-netif.git |
||
23 | * libosmo-sccp.git |
||
24 | * libsmpp34.git |
||
25 | * openbsc.git |
||
26 | * osmo-bts.git |
||
27 | * osmo-iuh.git |
||
28 | * osmo-pcu.git |
||
29 | 5 | zecke | * cellmgr-ng.git |
30 | 1 | zecke | * osmo-sip-connector.git |
31 | 30 | neels | |
32 | 1 | zecke | h2. Configuring Gerrit/Account |
33 | |||
34 | 10 | laforge | You will need to sign-up at https://gerrit.osmocom.org/login/. If you have an Osmocom Redmine account you can use https://osmocom.org/openid as OpenID provider. If you have no Osmocom redmine account, you can simply create one online at the "Register" link in the upper right corner. |
35 | |||
36 | Even without an existing or new redmine account, you should also be able to use any other OpenID provider to authenticate against gerrit (untested). |
||
37 | |||
38 | After the initial sign-up you will need to: |
||
39 | 1 | zecke | |
40 | * Pick a username (can not be changed) |
||
41 | * Add your public ssh key(s) |
||
42 | * Add email addresses you intend to use as author/comitter |
||
43 | 30 | neels | |
44 | If you would like to push private branches to the Gerrit repository, you also need to be added to the "known users" group. |
||
45 | Please send a short requesting email to openbsc@lists.osmocom.org. |
||
46 | 1 | zecke | |
47 | h2. Setting up Gerrit for commits and pushing |
||
48 | |||
49 | 33 | neels | *Note:* it is easiest to work with gerrit when gerrit is the only remote in your git clone. |
50 | When you clone from git.osmocom.org and add the gerrit remote, git will have two remotes, |
||
51 | 36 | neels | so when you first checkout a branch you have to supply the remote explicitly (cumbersome). |
52 | 34 | neels | The gerrit repositories and git.osmocom.org are constantly synced, so it is sufficient |
53 | to clone from gerrit only. |
||
54 | 33 | neels | |
55 | h3. Simplest: new clone |
||
56 | |||
57 | 35 | neels | * Create a new clone from gerrit |
58 | * Fetch the commit hook that adds Change-Id to each commit to uniquely identify a commit |
||
59 | 42 | neels | |
60 | 33 | neels | <pre> |
61 | git clone ssh://$USERNAME@gerrit.osmocom.org:29418/$PROJECT.git |
||
62 | scp -P 29418 $USERNAME@gerrit.osmocom.org:hooks/commit-msg $PROJECT/.git/hooks/ |
||
63 | </pre> |
||
64 | |||
65 | h3. SSH config |
||
66 | |||
67 | In '~/.ssh/config', add these lines: |
||
68 | <pre> |
||
69 | Host foo |
||
70 | Hostname gerrit.osmocom.org |
||
71 | Port 29418 |
||
72 | User $USERNAME |
||
73 | </pre> |
||
74 | (replace 'foo' with your favorite shortcut name, |
||
75 | replace '$USERNAME' with your user name as used on the gerrit website) |
||
76 | |||
77 | Then you can shorten above commands to |
||
78 | 1 | zecke | <pre> |
79 | 33 | neels | git clone ssh://foo/$PROJECT.git |
80 | 35 | neels | scp foo:hooks/commit-msg $PROJECT/.git/hooks/ |
81 | 33 | neels | </pre> |
82 | |||
83 | h3. Add gerrit to an existing clone |
||
84 | |||
85 | 7 | neels | * Add the remote to be able to fetch and push to gerrit |
86 | * Fetch the commit hook that adds Change-Id to each commit to uniquely identify a commit |
||
87 | |||
88 | <pre> |
||
89 | USERNAME=gerrit_user_name |
||
90 | PROJECT=$(basename $PWD) |
||
91 | 1 | zecke | git remote add gerrit ssh://$USERNAME@gerrit.osmocom.org:29418/$PROJECT.git |
92 | scp -P 29418 $USERNAME@gerrit.osmocom.org:hooks/commit-msg .git/hooks/ |
||
93 | </pre> |
||
94 | 44 | neels | |
95 | Now you need to use 'gerrit' instead of 'origin' in all of the other instructions shown |
||
96 | on this page. |
||
97 | |||
98 | 7 | neels | |
99 | 33 | neels | h2. Push for review |
100 | 1 | zecke | |
101 | 38 | neels | Checkout the revision or branch that you want to submit for review, then |
102 | |||
103 | 31 | neels | <pre> |
104 | 40 | neels | git push origin HEAD:refs/for/master |
105 | 1 | zecke | </pre> |
106 | 38 | neels | |
107 | 1 | zecke | You can optionally add a topic name with |
108 | 40 | neels | |
109 | <pre> |
||
110 | git push origin HEAD:refs/for/master/my_topic |
||
111 | 38 | neels | </pre> |
112 | |||
113 | 1 | zecke | |
114 | 38 | neels | h2. Push a "private" user branch |
115 | 33 | neels | |
116 | 1 | zecke | *Note* that you must be a member of the "known users" group, see above. |
117 | 33 | neels | |
118 | 43 | neels | If your local branch name is of the form 'your_name/topic', you can just |
119 | 1 | zecke | <pre> |
120 | git push |
||
121 | 33 | neels | </pre> |
122 | 41 | neels | and git will tell you what to do. |
123 | 1 | zecke | |
124 | 41 | neels | To push from a "nonstandard" local branch name, do |
125 | <pre> |
||
126 | git push origin HEAD:refs/heads/$USERNAME/branch_name |
||
127 | 33 | neels | </pre> |
128 | |||
129 | 39 | neels | |
130 | h2. List changesets in gerrit |
||
131 | |||
132 | 7 | neels | <pre> |
133 | git ls-remote origin changes/* |
||
134 | 2 | zecke | </pre> |
135 | 12 | msuraev | |
136 | 17 | neels | h1. Tips and Tricks |
137 | 1 | zecke | |
138 | 17 | neels | h2. Throw-away branch |
139 | |||
140 | If you need to adjust and re-submit patches, it may be handy to create a throw-away branch ("R D" in magit-gerrit in emacs for example), |
||
141 | make your changes/amendments and than send patch(es) back to gerrit while removing temporary branch automatically with "git review -f". |
||
142 | 13 | neels | |
143 | 25 | neels | h2. Re-submit a Branch with Amended Commits |
144 | 13 | neels | |
145 | 1 | zecke | On a feature branch, one typically has numerous commits that depend on their preceding commits. |
146 | 29 | neels | Often, some of the branch commits need to be amended for fixes. But, Gerrit will refuse your branch |
147 | re-submission if the first branch commit is unchanged. |
||
148 | 1 | zecke | |
149 | 16 | neels | To re-submit a branch, make sure to cosmetically tweak the branch's first commit log message |
150 | 22 | neels | before each re-submission (keep the Change-Id, really make just a cosmetic change). |
151 | 13 | neels | |
152 | 16 | neels | <pre> |
153 | git rebase -i master |
||
154 | # replace the first line's 'pick' with 'r' (or 'reword'), exit editor |
||
155 | # git presents you with commit log message, make any tiny modification. |
||
156 | 1 | zecke | </pre> |
157 | |||
158 | 29 | neels | The cause: Gerrit refuses to accept a commit with a Change-Id that it already knows and |
159 | where the commit hash is identical. |
||
160 | 1 | zecke | |
161 | 29 | neels | If you just cosmetically tweak the first commit's log message, the commit hash |
162 | is changed. Since the following commits contain their predecessor's commit hash, now |
||
163 | all of the branch's commit hashes are modified, and gerrit happily accepts them as a |
||
164 | new patch set. It will still pick up the Change-Ids (which you shouldn't edit) and |
||
165 | notice if commits have remained identical (keeping the votes). But with the minor |
||
166 | commit log tweak, it will no longer thwart your re-submission with an error message. |
||
167 | |||
168 | Note: you could modify all the Change-Ids, but now your branch submission would |
||
169 | open entirely new review entries and you would have to abandon your previous submission. |
||
170 | Comments on the first submission are lost and you cannot diff between patch sets. |
||
171 | |||
172 | |||
173 | 26 | neels | h2. Re-submit Previously Abandoned Changes |
174 | 16 | neels | |
175 | You have to edit the Change-Ids, on a branch that would be every single commit log message. |
||
176 | |||
177 | 13 | neels | <pre> |
178 | 1 | zecke | cd openbsc |
179 | git co my-branch |
||
180 | git rebase -i master |
||
181 | # replace all 'pick' with 'r' (or 'reword'), exit your editor |
||
182 | 13 | neels | # git presents each commit log message for editing |
183 | </pre> |
||
184 | |||
185 | 27 | neels | h2. Submit a "private" branch for master |
186 | 21 | neels | |
187 | If you've pushed a branch to refs/heads/* somewhere, gerrit will already know the Change-Ids on it. |
||
188 | 24 | neels | Make sure the option [[Gerrit#Private-Branches-Create-a-new-change-for-every-commit|Create a new change for every commit not in the target branch]] is _TRUE_ for your project, |
189 | 21 | neels | or gerrit will refuse to accept your submission. |
190 | |||
191 | 16 | neels | h1. Reasons for Particular Configuration |
192 | 13 | neels | |
193 | 16 | neels | h2. Rebase if necessary |
194 | |||
195 | There are different merge strategies that Gerrit performs to accept patches. |
||
196 | 13 | neels | Each project can be configured to a specific merge strategy, but unfortunately you can't |
197 | decide on a strategy per patch submission. |
||
198 | |||
199 | It seems that the "Merge if Necessary" strategy is best supported, but it creates non-linear |
||
200 | history with numerous merge commits that are usually not at all necessary. |
||
201 | |||
202 | Instead, the "Cherry Pick" strategy puts each patch onto current master's HEAD to create |
||
203 | linear history. However, this will cause merge failures as soon as one patch depends on |
||
204 | another submitted patch, as typical for a feature branch submission. |
||
205 | |||
206 | 1 | zecke | So we prefer the "Rebase if Necessary" strategy, which always tries to apply your patches to |
207 | 13 | neels | the current master HEAD, in sequence with the previous patches on the same branch. |
208 | However, some problems still remain, including some bugs in "Rebase if Necessary". |
||
209 | 1 | zecke | |
210 | 13 | neels | There's a problem with "Rebase if Necessary": If your branch sits at master's HEAD, Gerrit |
211 | refuses to accept the submission, because it thinks that no new changes are submitted. |
||
212 | This is a bug in Gerrit, which holger has fixed manually in our Gerrit installation: |
||
213 | 1 | zecke | |
214 | https://bugs.chromium.org/p/gerrit/issues/detail?id=4158 |
||
215 | |||
216 | |||
217 | 16 | neels | h2. Private Branches: Create a new change for every commit... |
218 | 1 | zecke | |
219 | 13 | neels | Say you have an extensive feature in development, and you want to keep it on the |
220 | upstream git repository to a) keep it safe and b) collaborate with other devs on it. |
||
221 | 16 | neels | So, of course, you have regularly pushed to refs/heads/yoyodyne/feature. |
222 | 13 | neels | |
223 | Since you have the gerrit commit hook installed, your feature branch already has |
||
224 | Change-Id tags in all commit log messages. |
||
225 | |||
226 | Now your feature is complete and you would like to submit it to master. |
||
227 | Alas, Gerrit refuses to accept your patch submission for master, because it |
||
228 | knows the Change-Ids are also on a different branch. |
||
229 | |||
230 | 16 | neels | Gerrit by default enforces that a Change-Id must be unique across all branches, |
231 | so that each submission for review is separate for each branch. Instead, we |
||
232 | want to handle Change-Ids per-branch, so that you can have the same change |
||
233 | submitted to different branches, as separate patch submissions, without having |
||
234 | to cosmetically adjust the Change-Id. |
||
235 | 13 | neels | |
236 | 16 | neels | Solution: set the option |
237 | _Create a new change for every commit not in the target branch_ to _TRUE_ |
||
238 | 13 | neels | |
239 | 20 | neels | h2. Allow content merges |
240 | 14 | neels | |
241 | By default, gerrit compares patches only by the files' paths. If two paths are the same, |
||
242 | it immediately shows them as conflicts (path conflicts). |
||
243 | |||
244 | In software development, a conflict usually means an actual content conflict, so if the |
||
245 | edits are in two entirely separate places in the file, we don't consider this a conflict. |
||
246 | |||
247 | 23 | neels | By setting _Allow content merges_ to _TRUE_ in the git project config, we tell Gerrit to |
248 | 14 | neels | perform text merges of the submitted patches and only complain about actual content |
249 | conflicts, in the usual software engineering sense. |
||
250 | 32 | neels | |
251 | h1. Admin |
||
252 | |||
253 | h2. Adding users to groups |
||
254 | |||
255 | Normally, the gerrit UI auto-completes a user name in the edit field. It has happened |
||
256 | though that an existing user is not auto-completed, as if it didn't exist. In that case, |
||
257 | find out the user ID (seven digit number like 1000123) and just enter that. |
||
258 | |||
259 | The user ID can be found on the user's "Settings" page, or in the database (s.b.). |
||
260 | |||
261 | h2. Querying the database directly |
||
262 | |||
263 | If your user has permission to access the database, you can place SQL queries using the |
||
264 | 'gerrit gsql' commands over ssh: |
||
265 | |||
266 | <pre> |
||
267 | ssh -p 29418 $USERNAME@gerrit.osmocom.org 'gerrit gsql --format PRETTY -c "show tables"' |
||
268 | ssh -p 29418 $USERNAME@gerrit.osmocom.org 'gerrit gsql --format PRETTY -c "select full_name,account_id from accounts"' |
||
269 | </pre> |
||
270 | |||
271 | This seems to be the MySQL dialect. |