Bug #4855
closed
ns2: Better formatting for show ns
Added by daniel over 3 years ago.
Updated over 2 years ago.
Description
The current formatting when running show ns looks rather weird and confusing:
OsmoGbProxy# show ns
UDP bind: 127.0.0.100:23000 dcsp: 0
1 NS-VC:
udp)[127.0.0.100]:23000<101>[192.168.100.239]:7777
NSEI 101
:47808 <> 192.168.100.239:7777Remote: udp)[127.0.0.100]:23000<101>[192.168.100.239]:7777 UDP
- % Done changed from 0 to 20
With https://gerrit.osmocom.org/c/libosmocore/+/21062 the output looks better already:
OsmoGbProxy# show ns
UDP bind: 127.0.0.100:23000 dcsp: 0
1 NS-VC:
udp)[127.0.0.100]:23000<101>[192.168.100.239]:7777
NSEI 101
udp)[127.0.0.100]:23000<101>[192.168.100.239]:7777
We still print the nsvc twice - once in dump_bind and once in dump_nse. dump_bind doesn't seem to be implemented for every bind, though and the ns2_ll_str function is quite incomplete when dealing with non-udp nsvc.
lynxis: What do you think, should we just print the NSVC in dump_nse and not in dump_bind?
- Category set to libosmogb
lynxis: What do you think, should we just print the NSVC in dump_nse and not in dump_bind?
good idea.
Maybe have a different command to `show ns binds`
I think lynxis merged some related patches recently?
- Related to Bug #4797: vty: the output of 'show ns' command is confusing added
- Checklist item deleted (
Implement gprs_ns2_ll_str_buf for E1)
- Status changed from New to Closed
- Assignee changed from daniel to lynxis
- % Done changed from 20 to 100
The `show ns` has been improved and gprs_ns2_ll_str() has been implemented for the other link layers.
Also available in: Atom
PDF